[MINOR][CONNECT][PYTHON] Fix stale running-task count in progress bar - #57545
Open
fallintoplace wants to merge 1 commit into
Open
[MINOR][CONNECT][PYTHON] Fix stale running-task count in progress bar#57545fallintoplace wants to merge 1 commit into
fallintoplace wants to merge 1 commit into
Conversation
Generated-by: OpenAI API
Member
|
Do you happen to know which change caused this regerssion? |
uros-b
approved these changes
Jul 26, 2026
Member
|
Thank you @fallintoplace! |
Contributor
Author
|
@HyukjinKwon I traced it back to #45150 (f6999df, [SPARK-47081][CONNECT] Support Query Execution Progress), committed on April 4, 2024. The original Progress.update_ticks() implementation already called output() before assigning self._running. The follow-up in #45907 kept the same ordering, so this appears to have been present since the Connect progress bar was introduced rather than caused by a later change. |
HyukjinKwon
approved these changes
Jul 26, 2026
Member
|
Let's actually file a JIRA |
Contributor
Author
|
Should I do this or are you on it? I can file a JIRA ticket in 20 hours. @HyukjinKwon |
Contributor
Author
|
I don't have an account though, maybe someone can do this. I will need to wait for access. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Update the running-task and stage state before rendering the Spark Connect progress bar. Add a regression assertion for the displayed running-task count.
Why are the changes needed?
Progress.update_ticks()previously calledoutput()before storing the latestinflight_tasksvalue. Each progress message therefore displayed the running-task count from the previous update.For example, the first update with 10 running tasks displayed
0 Tasks running. This change ensures that the rendered message uses values from the same progress update.Does this PR introduce any user-facing change?
Yes. The Spark Connect progress bar now displays the current running-task count instead of the count from the previous update.
How was this patch tested?
Added a regression assertion to
ProgressBarTest.test_simple_progress.All five tests passed. Ruff lint and formatting checks also passed.
Was this patch authored or co-authored using generative AI tooling?
No